RHDH 1.9 aligment and bitbucket revert#2816
Open
eloycoto wants to merge 2 commits intoredhat-developer:mainfrom
Open
RHDH 1.9 aligment and bitbucket revert#2816eloycoto wants to merge 2 commits intoredhat-developer:mainfrom
eloycoto wants to merge 2 commits intoredhat-developer:mainfrom
Conversation
Code Review by Qodo
|
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
Review Summary by QodoRevert Bitbucket fix and align dependencies with RHDH 1.9
WalkthroughsDescription• Revert Bitbucket RepoUrlPicker wrapper implementation and workaround • Align dependencies with RHDH 1.9 versions for consistency • Remove custom X2ARepoUrlPicker extension from exports and usage • Update package.json resolutions to match RHDH 1.9 specifications Diagramflowchart LR
A["Bitbucket Workaround Code"] -->|Remove| B["RepoUrlPickerWithBitbucketFix"]
C["X2ARepoUrlPickerExtension"] -->|Remove| D["Plugin Exports"]
E["Package Dependencies"] -->|Align| F["RHDH 1.9 Versions"]
B -->|Delete| G["Test File Removed"]
D -->|Remove| H["App.tsx Usage"]
File Changes1. workspaces/x2a/plugins/x2a/src/index.ts
|
eloycoto
force-pushed
the
BitbucketFix
branch
5 times, most recently
from
0f94dda to
4aefa0b
Compare
)" This reverts commit d8c241a.
eloycoto
force-pushed
the
BitbucketFix
branch
3 times, most recently
from
0886bc1 to
8bf1024
Compare
From the RHDH 1.9 container:
```
sh-5.1$ grep -B1 -A3 "\"@backstage/plugin-permission-backend@" /opt/app-root/src/yarn.lock
"@backstage/plugin-permission-backend@npm:0.7.3":
version: 0.7.3
resolution: "@backstage/plugin-permission-backend@npm:0.7.3"
dependencies:
"@backstage/backend-plugin-api": ^1.4.2
"@backstage/config": ^1.3.3
sh-5.1$ grep -B1 -A3 "\"@backstage/plugin-scaffolder@" /opt/app-root/src/yarn.lock
"@backstage/plugin-scaffolder@npm:1.34.3":
version: 1.34.3
resolution: "@backstage/plugin-scaffolder@npm:1.34.3"
dependencies:
"@backstage/catalog-client": ^1.12.1
"@backstage/catalog-model": ^1.7.6
sh-5.1$ grep -B1 -A3 "\"@backstage/plugin-scaffolder-react@" /opt/app-root/src/yarn.lock
"@backstage/plugin-scaffolder-react@npm:1.19.3, @backstage/plugin-scaffolder-react@npm:^1.19.3":
version: 1.19.3
resolution: "@backstage/plugin-scaffolder-react@npm:1.19.3"
dependencies:
"@backstage/catalog-client": ^1.12.1
"@backstage/catalog-model": ^1.7.6
sh-5.1$ grep -B1 -A3 "\"@backstage/integration-react@" /opt/app-root/src/yarn.lock
"@backstage/integration-react@npm:1.2.12, @backstage/integration-react@npm:^1.2.12":
version: 1.2.12
resolution: "@backstage/integration-react@npm:1.2.12"
dependencies:
"@backstage/config": ^1.3.6
"@backstage/core-plugin-api": ^1.12.0
sh-5.1$ grep -B1 -A3 "\"@backstage/core-plugin-api@" /opt/app-root/src/yarn.lock
"@backstage/core-plugin-api@npm:1.12.0":
version: 1.12.0
resolution: "@backstage/core-plugin-api@npm:1.12.0"
dependencies:
"@backstage/config": ^1.3.6
"@backstage/errors": ^1.2.7
--
"@backstage/core-plugin-api@npm:^1.12.0, @backstage/core-plugin-api@npm:^1.12.1":
version: 1.12.1
resolution: "@backstage/core-plugin-api@npm:1.12.1"
dependencies:
"@backstage/config": ^1.3.6
"@backstage/errors": ^1.2.7
```
Now versions are aligned correctly.
Signed-off-by: Eloy Coto <[email protected]>
Code Review by Qodo
|
|
Review Summary by QodoRevert Bitbucket fix and align with RHDH 1.9 dependencies
WalkthroughsDescription• Reverted Bitbucket RepoUrlPicker wrapper and related code • Aligned dependencies with RHDH 1.9 versions • Removed X2ARepoUrlPickerExtension export and usage • Updated package.json dependencies to match RHDH 1.9 • Restored standard RepoUrlPicker in templates Diagramflowchart LR
A["Bitbucket Wrapper Code"] -->|Removed| B["RepoUrlPickerWithBitbucketFix"]
C["X2ARepoUrlPickerExtension"] -->|Deleted| D["Plugin Exports"]
E["RHDH 1.9 Dependencies"] -->|Aligned| F["package.json versions"]
G["Templates"] -->|Reverted to| H["Standard RepoUrlPicker"]
File Changes1. workspaces/x2a/plugins/x2a/src/index.ts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
revert bitbucket commit
Added the same dependencies as RHDH 1.9.